Improve exception diagnostics for stdio client#376
Merged
stephentoub merged 2 commits intomodelcontextprotocol:mainfrom May 14, 2025
Merged
Improve exception diagnostics for stdio client#376stephentoub merged 2 commits intomodelcontextprotocol:mainfrom
stephentoub merged 2 commits intomodelcontextprotocol:mainfrom
Conversation
halter73
reviewed
May 1, 2025
src/ModelContextProtocol/Protocol/Transport/StdioClientSessionTransport.cs
Outdated
Show resolved
Hide resolved
src/ModelContextProtocol/Protocol/Transport/StdioClientSessionTransport.cs
Show resolved
Hide resolved
src/ModelContextProtocol/Protocol/Transport/StreamClientSessionTransport.cs
Outdated
Show resolved
Hide resolved
tests/ModelContextProtocol.Tests/Transport/StdioClientTransportTests.cs
Outdated
Show resolved
Hide resolved
halter73
approved these changes
May 2, 2025
Track the last several lines of stderr and include those in an exception created as part of CleanupAsync if the server process has already exited. This is based on an assumption that the server should never exit prior to CleanupAsync being called.
This was referenced Jul 24, 2025
jeffhandley
added
the
breaking-change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #362